Exit non-zero when rd-jobs load has a job load failure [#285 state:ne…

…eds_verification]

core/src/java/com/dtolabs/rundeck/core/cli/jobs/JobsTool.java

@@ -658,6 +658,9 @@ private void loadAction() throws JobsToolException {
                 logStoredJobItem(item, null);
             }
         }
+        if(failed.size()>0) {
+            throw new JobsToolException("Failed to load " + failed.size() + " Jobs");
+        }
 
     }
 

test/test.jobs2.xml

@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+
+Jobs should fail due to missing project
+-->
+<joblist>
+  <job>
+    <name>Invalid Job</name>
+    <description>Loading this job should not succeed</description>
+    <additional/>
+    <loglevel>INFO</loglevel>
+    <group>test</group>
+    <context>
+      <project>thisProjectDNE</project>
+    </context>
+    <sequence threadcount="1" keepgoing="false" strategy="node-first">
+      <command>
+        <exec>uptime</exec>
+      </command>
+    </sequence>
+    <dispatch>
+      <threadcount>1</threadcount>
+      <keepgoing>false</keepgoing>
+    </dispatch>
+  </job>
+</joblist>

test/test.sh

@@ -43,6 +43,30 @@ fi
 rm $DIR/load.out
 rm $DIR/test.jobs.expanded.xml
 
+
+###############
+# load jobs with failures
+###############
+#
+#copy jobs file to replace template
+
+#load jobs
+$RDECK_BASE/tools/bin/rd-jobs load -f $DIR/test.jobs2.xml > $DIR/load.out
+if [ 1 != $? ] ; then
+	echo Should have failed to load a job: $!
+	exit 2
+fi
+cat $DIR/load.out
+
+grep -q Failed $DIR/load.out 
+if [ 1 == $? ] ; then
+	echo Should have failed to load a job: $!
+	exit 2
+fi
+
+rm $DIR/load.out
+
+
 # try to run job id 1
 
 $RDECK_BASE/tools/bin/run -i 1