Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to use a pure rust lib rather than onig? #74

Closed
gilescope opened this issue Mar 2, 2020 · 8 comments · Fixed by #79 or #81
Closed

Is it possible to use a pure rust lib rather than onig? #74

gilescope opened this issue Mar 2, 2020 · 8 comments · Fixed by #79 or #81

Comments

@gilescope
Copy link

Is it possible to use a pure rust lib rather than onig? I'm mostly asking this question so that the answer is documented. When it's not pure rust people can have trouble compiling with gcc on windows on gnu toolchain - it requires more setup and configuration of a windows machine than just installing rustup.

As I said I'm sure there's some good reasons behind using onig versus depending on some parts of ripgrep, just would be nice to know so that I can stop wondering.... :-)

@dtolnay
Copy link
Owner

dtolnay commented Mar 2, 2020

This crate doesn't use onig, it is pulled in through syntect. I am sad about it too. trishume/syntect#12

@gilescope
Copy link
Author

Seems like soonish there might be a fancy-regex feature: trishume/syntect#270

Sent with GitHawk

@trishume
Copy link

The fancy-regex mode was just merged and released as v4.0.0! You may want to try using it to fix this issue, although it does halve performance so you may only want to use it on platforms where it's needed.

Still hoping that onig's build will eventually improve but for now fancy-regex is a good option.

@gilescope
Copy link
Author

Even as a feature that’s helpful. Ideally a bit of the readme can just say for the max-rust version do ‘X’.

Sent with GitHawk

@trishume
Copy link

I've already added such a section to the Readme :)

@gilescope
Copy link
Author

Thanks - I was thinking of the readme for cargo-expand as that’s where people will look for it initially.

Sent with GitHawk

@dtolnay
Copy link
Owner

dtolnay commented Apr 20, 2020

Fixed in 0.5.0.

@gilescope
Copy link
Author

Beautiful, thanks to everyone involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants