New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug assert that rust::Slice isn't constructed with C++ null ptr #788

Merged

dtolnay merged 1 commit into master from nullslice

Mar 28, 2021

Owner

dtolnay commented Mar 28, 2021 •

edited

According to https://doc.rust-lang.org/std/slice/fn.from_raw_parts.html#safety:

data must be non-null and aligned even for zero-length slices. One reason for this is that enum layout optimizations may rely on references (including slices of any length) being aligned and non-null to distinguish them from other data.


          Debug assert that rust::Slice isn't constructed with C++ null ptr

96ee470

dtolnay merged commit a66ad27 into master

dtolnay deleted the nullslice branch

March 28, 2021 06:08

dtolnay mentioned this pull request

Allow slice null ptr safely if slice is empty #789

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment