Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce histogram for configurable lints #3

Open
dtolnay opened this issue Sep 14, 2021 · 0 comments
Open

Produce histogram for configurable lints #3

dtolnay opened this issue Sep 14, 2021 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@dtolnay
Copy link
Owner

dtolnay commented Sep 14, 2021

For example too_many_arguments: it would be relevant to know the distribution of number of arguments among functions where this lint is being suppressed. The current default threshold in Clippy is 7. Is it the case that almost all suppression are using 8 arguments, or 8 or 9? Or is it a much wider distribution? That would be relevant for informing a choice of better default.

Similarly type_complexity: what is the distribution of actual complexity?

These 2 lints specifically are the top two most widely suppressed lints in Clippy. I think it's a reasonable takeaway that Clippy has gotten the default threshold wrong in both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant