Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider support for rust-toolchain.toml #77

Closed
dsherret opened this issue Mar 9, 2023 · 3 comments
Closed

Reconsider support for rust-toolchain.toml #77

dsherret opened this issue Mar 9, 2023 · 3 comments

Comments

@dsherret
Copy link

dsherret commented Mar 9, 2023

I have just noticed that this project does not support the rust-toolchain.toml file because the latest rust release broke all our CI runs because of sparse registry support being opted into by this action.

In #12 (now locked) it was mentioned that you would prefer to not add support for rust-toolchain.toml files, but it is valuable to only have the version defined in one place (we often found people forgot to keep the version between the yml and toolchain file in sync). Is there a reason not to add this?

@dtolnay
Copy link
Owner

dtolnay commented Mar 9, 2023

I'd still prefer not to support it.

@dtolnay dtolnay closed this as completed Mar 9, 2023
@dsherret
Copy link
Author

dsherret commented Mar 9, 2023

That's too bad. I'll create my own basic solution.

@dsherret
Copy link
Author

dsherret commented Mar 9, 2023

Ok, I really needed this so I created https://github.com/dsherret/rust-toolchain-file based on a fork of this for anyone who wants this functionality.

Repository owner locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants