Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please define Predicate to not allow patch version without minor version #89

Closed
joshtriplett opened this issue Aug 9, 2016 · 1 comment
Milestone

Comments

@joshtriplett
Copy link

The definition of Predicate includes an Option<u64> for minor and for patch; that type would allow a predicate with a patch but no minor. That causes a match expression on a Predicate to complain about missing cases. Please consider using an enum that doesn't allow that case; for instance:

enum Something { M(u64), MM(u64,u64), MMP(u64,u64,u64) }
@steveklabnik steveklabnik added this to the 1.0 milestone Aug 10, 2016
@dtolnay
Copy link
Owner

dtolnay commented May 25, 2021

On balance, I think the current representation is better.

@dtolnay dtolnay closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants