Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fold #43

Closed
dtolnay opened this issue Oct 17, 2016 · 2 comments
Closed

Implement fold #43

dtolnay opened this issue Oct 17, 2016 · 2 comments

Comments

@dtolnay
Copy link
Owner

dtolnay commented Oct 17, 2016

Here is how libsyntax does it: https://github.com/rust-lang/rust/blob/master/src/libsyntax/fold.rs

cc @SimonSapin

@SimonSapin
Copy link
Contributor

Why a separate crate?

@dtolnay
Copy link
Owner Author

dtolnay commented Nov 11, 2016

I am hesitant to pile more features into syn because if an optional feature requires a breaking change, even people not using that feature suffer from the version bump. With a relatively stable core in syn and an ecosystem of supporting libraries around it, you are only affected by breaking changes to pieces that you use.

I guess fold is core enough and coupled so closely with everything else in syn that the scenario of breaking fold without breaking syn seems unlikely, so you're right it could make sense to implement here rather than a separate crate.

@dtolnay dtolnay changed the title Implement fold in a separate crate Implement fold Nov 11, 2016
@gnzlbg gnzlbg mentioned this issue Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants