How does BlockCheckMode differ from Unsafety?

[shepmaster]

pub enum BlockCheckMode {
    Default,
    Unsafe,
}

pub enum Unsafety {
    Unsafe,
    Normal,
}

Other than the ordering and choice of Normal vs Default, do these really differ from each other?

[dtolnay]

Good catch! Looks like this came from libsyntax where they have:

pub enum BlockCheckMode {
    Default,
    Unsafe(UnsafeSource),
}

pub enum Unsafety {
    Unsafe,
    Normal,
}

It makes so much more sense there because they keep track of:

pub enum UnsafeSource {
    CompilerGenerated,
    UserProvided,
}

We're never going to need UnsafeSource so I will plan to unify these in the next breaking release of syn.

[dtolnay]

Fixed in 7b03591.

[dtolnay]

I released this change in 0.11.0.

[RReverser]

@dtolnay Looks like you released it in 0.10.7 because @SimonSapin bumped version as part of his commit 07c7341 and thus broke semver - our build started failing with Use of undeclared type or module `BlockCheckMode` when Cargo started auto-pulling 0.10.7 instead of 0.10.6 :(