Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edition and MSRV with trybuild #203

Closed
TedDriggs opened this issue Oct 26, 2022 · 3 comments
Closed

Edition and MSRV with trybuild #203

TedDriggs opened this issue Oct 26, 2022 · 3 comments

Comments

@TedDriggs
Copy link

derive_builder uses trybuild and has started getting CI failures on its MSRV of 1.40 because once_cell is using the 2021 edition. Happily, we're only using trybuild with 1.59, so I think this problem goes away if I can find a way to avoid 1.40 ever encountering the trybuild dependency.

Unfortunately, rust-lang/cargo#1596 doesn't seem to have any movement, so I'm a bit stumped on how to proceed.

My first thought was to move these tests to their own crate, but I don't know if there's a good way to conditionally include a crate in a workspace so I'm not sure if that actually changes anything for me.

@dtolnay
Copy link
Owner

dtolnay commented Oct 26, 2022

rust-lang/cargo#1596 (comment) describes an idiom for optional dev-dependencies.

@dtolnay dtolnay closed this as completed Oct 26, 2022
@TedDriggs
Copy link
Author

Can that be used to target a particular rust version?

@dtolnay
Copy link
Owner

dtolnay commented Oct 26, 2022

Yes if your CI only enables cfg(skip_ui_tests) on particular rust versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants