Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge with bitcoin 0.17 #41

Closed
scravy opened this issue Aug 27, 2018 · 8 comments · Fixed by #1013
Closed

merge with bitcoin 0.17 #41

scravy opened this issue Aug 27, 2018 · 8 comments · Fixed by #1013
Assignees
Labels
upstream sync Related to upstream merges
Milestone

Comments

@scravy
Copy link
Member

scravy commented Aug 27, 2018

bitcoin-core branched 0.17 off and a new release is lurking around the corner. We should take the opportunity and catch up!

@scravy
Copy link
Member Author

scravy commented Aug 31, 2018

bitcoin 0.17 is polished, branched off of master: https://github.com/bitcoin/bitcoin/tree/0.17

0.17 is supposed to be released 2018-09-08 according to bitcoins release schedule: bitcoin/bitcoin#12624

@scravy scravy added this to the Catch up with bitcoin 0.17 milestone Sep 4, 2018
@scravy scravy added the upstream sync Related to upstream merges label Sep 4, 2018
@scravy
Copy link
Member Author

scravy commented Dec 10, 2018

We're going to do ASAP once #212 is merged.

@cornelius cornelius removed this from the Catch up with bitcoin 0.17 milestone Jan 22, 2019
@thothd thothd added this to the 0.1 milestone Jan 22, 2019
@dtr-org dtr-org deleted a comment from mergeable bot Jan 30, 2019
@dtr-org dtr-org deleted a comment from mergeable bot Jan 30, 2019
@cornelius
Copy link
Member

Bitcoin Core has branched 0.18 now: https://github.com/bitcoin/bitcoin/tree/0.18. It aims at a 0.18.0 release on Apr 3 2019 (bitcoin/bitcoin#14438).

@scravy
Copy link
Member Author

scravy commented Mar 4, 2019

Bitcoin Core has branched 0.18 now: https://github.com/bitcoin/bitcoin/tree/0.18. It aims at a 0.18.0 release on Apr 3 2019 (bitcoin/bitcoin#14438).

Sounds like something which would fit a "merge with bitcoin 0.18" ticket?

@cornelius
Copy link
Member

As you wish 😉: #727

The questions we need to answer are, when we want to do the merge, and if we do 0.17 first and then 0.18 or go straight to 0.18.

@scravy
Copy link
Member Author

scravy commented Mar 4, 2019

I for one think we should separate these. It might be a bit more work. 0.17 is mostly refactorings whereas 0.18 introduces completely new features (new BIPs, partially signed transactions for example; removal of accounts, removal of generate call, etc.).

Also as we want to keep merging with bitcoin I think it's good to exercise this procedure.

@cornelius
Copy link
Member

Also as we want to keep merging with bitcoin I think it's good to exercise this procedure.

👍

@thothd
Copy link
Member

thothd commented Mar 4, 2019

Also as we want to keep merging with bitcoin I think it's good to exercise this procedure.

👍

I agree with @scravy, but anyway it's also a matter of release schedule, 0.18 won't event fit theoretically to be merged pre testnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream sync Related to upstream merges
Projects
No open projects
4 participants
@cornelius @scravy @thothd and others