Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up client version handling #980

Open
cornelius opened this issue Apr 15, 2019 · 0 comments
Open

Clean up client version handling #980

cornelius opened this issue Apr 15, 2019 · 0 comments
Labels
technical debt Cleaning up code which is there for historical reasons
Milestone

Comments

@cornelius
Copy link
Member

The Bitcoin Core codebase has a couple of places where there are checks on the client version to enable features which where introduced in certain releases. As we are starting fresh in Unit-e, we have all these features from the beginning so there is no need for these conditionals right now. We will need this at some point in the future, though, when we introduce features which need to be backwards compatible in some way. This depends on the nature of the features.

For now we have only done a minimal change to introduce the unit-e version number (#945, #969). We should revisit this question and evaluate how we can do it in a cleaner way which suits the needs of unit-e while still allowing us to sync with upstream.

@cornelius cornelius added the technical debt Cleaning up code which is there for historical reasons label Apr 15, 2019
@cornelius cornelius added this to the 1.0 milestone Apr 15, 2019
@thothd thothd modified the milestones: 1.0, 0.2 Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Cleaning up code which is there for historical reasons
Projects
None yet
Development

No branches or pull requests

2 participants