After captured Image or recorded video

[mskocabay]

After completed camera operations , I want to show image or video in other actvity .
Is that true ?

In PhotographerActivity.java i added to announcingNewFile method these codes. Is it enogh or must i do something about stop camera or backgroundtasks?

Thank you

            ` private void announcingNewFile(String filePath) {
	Toast.makeText(PhotographerActivity.this, "File: " + filePath, Toast.LENGTH_SHORT).show();
	Utils.addMediaToGallery(PhotographerActivity.this, filePath);
	
	finish();

	try {
		Thread.sleep(500);
	} catch (InterruptedException e) {
		e.printStackTrace();
	}


	Intent intent = new Intent(PhotographerActivity.this,PreviewActivity.class);
	intent.putExtra("mode",0);
	intent.putExtra("file",filePath);
	startActivity(intent);

}`

[duanhong169]

The PhotographerActivity.onPause() method stops the camera and background tasks for you:

Camera/app/src/main/java/top/defaults/cameraapp/PhotographerActivity.java

Lines 297 to 301 in d9fd8b4

	protected void onPause() {
	finishRecordingIfNeeded();
	photographer.stopPreview();
	super.onPause();
	}

So if you have kept the onPause() implementation, then there is no need to do it anymore.

[mskocabay]

Thank you very much , it is best camera2 example. I tried it but returns this error in andoid 6

FATAL EXCEPTION: main
Process: arge.aa.com.myapplication, PID: 10109
java.lang.RuntimeException: Unable to pause activity {com.camera.myapplication/arge.aa.com.myapplication.PhotographerActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean

and in android 8

FATAL EXCEPTION: main
Process: arge.aa.com.myapplication, PID: 19986
java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.os.Handler.post(java.lang.Runnable)' on a null object reference
at arge.aa.com.myapplication.Camera2Photographer$4.onImageAvailable(Camera2Photographer.java:195)
at android.media.ImageReader$ListenerHandler.handleMessage(ImageReader.java:812)
at android.os.Handler.dispatchMessage(Handler.java:108)
at android.os.Looper.loop(Looper.java:166)
at android.app.ActivityThread.main(ActivityThread.java:7425)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:245)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:921)

[duanhong169]

Seems that the onShotFinished() is called too early, and the image is not finished saving at that time:

Camera/camera/src/main/java/top/defaults/camera/Camera2Photographer.java

Lines 961 to 967 in d9fd8b4

	@Override
	public void onCaptureCompleted(@NonNull CameraCaptureSession session,
	@NonNull CaptureRequest request,
	@NonNull TotalCaptureResult result) {
	unlockFocus();
	callbackHandler.onShotFinished(nextImageAbsolutePath);
	}

then when the ImageSaver try to save the image, the backgroundHandler has been set to null by onPause():

Camera/camera/src/main/java/top/defaults/camera/Camera2Photographer.java

Lines 185 to 193 in d9fd8b4

	private final ImageReader.OnImageAvailableListener onImageAvailableListener
	= new ImageReader.OnImageAvailableListener() {
	@Override
	public void onImageAvailable(ImageReader reader) {
	backgroundHandler.post(new ImageSaver(reader.acquireLatestImage(), nextImageAbsolutePath));
	}
	};

I think we could try to put the event:

Camera/camera/src/main/java/top/defaults/camera/Camera2Photographer.java

Line 966 in d9fd8b4

callbackHandler.onShotFinished(nextImageAbsolutePath);

after:

Camera/camera/src/main/java/top/defaults/camera/Camera2Photographer.java

Line 190 in d9fd8b4

backgroundHandler.post(new ImageSaver(reader.acquireLatestImage(), nextImageAbsolutePath));

@mskocabay I'm sorry I have no enough time to debug this issue, could you please try to solve this by your own and it's much better if you can create a pull request if applicable.

[mskocabay]

ok thank you very much