Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about DDIM loss #26

Open
zyp-byte opened this issue Aug 2, 2023 · 2 comments
Open

Question about DDIM loss #26

zyp-byte opened this issue Aug 2, 2023 · 2 comments

Comments

@zyp-byte
Copy link

zyp-byte commented Aug 2, 2023

Hi, thanks for your wonderful work!
When I was reading the code, I noticed that you took the time embedding on the feature extracted from the RGB images. I am wondering if it is better to take the time embedding on the depth output by the decoder (namely 'refined_depth' defined in your code), or just annotated depth with masks.
Thanks for your work and codes again!

@duanyiqun
Copy link
Owner

Hi, thanks for your question.
At that time our thinking is more like to add the time embedding on a dense and consistent feature. This way is closer to the original diffusion model. I haven't try to put time embedding directly on depth map.
Have you got any attempts on that? If the results are positive, I'm keen to have a improved version with you.

@VLadImirluren
Copy link

Hi, thanks for your question. At that time our thinking is more like to add the time embedding on a dense and consistent feature. This way is closer to the original diffusion model. I haven't try to put time embedding directly on depth map. Have you got any attempts on that? If the results are positive, I'm keen to have a improved version with you.

Hi ! Thanks to your nice job.
I notive that you choose to predict the x0 instead of noise like DDPM.
Can you share the reason with me?
Thanks again~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants