Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "only change lines" to inspections #35

Closed
dubreuia opened this issue Apr 12, 2016 · 6 comments
Closed

Add "only change lines" to inspections #35

dubreuia opened this issue Apr 12, 2016 · 6 comments

Comments

@dubreuia
Copy link
Owner

Add the option for each one individually.

It should have the same mechanism than #34.

@dubreuia
Copy link
Owner Author

WNF

@Robrowski
Copy link

Can this be reconsidered? The inclusions/exclusions is going to help me get by for a while, but ultimately I will have to stop using the plugin altogether without a feature like this. The inspections end up being far too disruptive for my team's code review process.

@dubreuia
Copy link
Owner Author

Sure! I'm reopening.

I'll be honest thought this is a big development and it's not priority since it's very specific (lot's of bugs to correct before that). I'm not seing this done anytime soon without help from a PR.

@dubreuia dubreuia reopened this Jun 29, 2017
@aalosious
Copy link

+1 on the enhancement.. The Eclipse "Save Actions" already supports this.

Below is why this would be a big enhancement for my use case:
I often keep manual formatting to enhance readability and uncluttering (like adding newlines where the auto-formatter wouldn't). Right now, I have to worry about the plugin undoing my uncommitted formatting changes. So, I have to either untick the "Reformat file" option in the plugin or commit my changes to git before continuing. This limits the use of the plugin for me. So, if the plugin could diff with the last saved state of the file (rather than the last git committed version of the file) before formatting, it would be great.

Thanks for the effort, dubreuia.

@dubreuia
Copy link
Owner Author

Hello @aalosious, I'm not sure this plugin fits your use case: you either have a formatter that fits your usage and save-actions applies it automatically, or you don't use auto-something at all and do everything by hand.

For some files you might want to temporarily stop auto-formatting (like: "don't reformat this file on next save") and that development is in #59

@dubreuia dubreuia changed the title Add "only change lines" to inspections quick fixes [Java quickfix] Add "only change lines" to inspections Aug 24, 2017
@dubreuia dubreuia changed the title [Java quickfix] Add "only change lines" to inspections Add "only change lines" to inspections Jan 18, 2019
@dubreuia dubreuia added this to proposed in Save Actions - Ideas Sep 11, 2020
@dubreuia dubreuia moved this from proposed to need help in Save Actions - Ideas Sep 11, 2020
@dubreuia
Copy link
Owner Author

Moved to "ideas"

@dubreuia dubreuia moved this from good first issue to need help in Save Actions - Ideas Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants