Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect rpm return value in FSCalculation.calculation #7

Closed
spanner888 opened this issue Jul 1, 2021 · 1 comment
Closed

Incorrect rpm return value in FSCalculation.calculation #7

spanner888 opened this issue Jul 1, 2021 · 1 comment

Comments

@spanner888
Copy link
Contributor

While scripting with your great addon, I noticed that overrides of rpm where being ignored in returned rpm.

Cause seems to be return variable is "rpm", but "calc_rpm" is used if rpm override is triggered and also used for all the calculations, but then "rpm" is used in the return.

I have not submitted pull request, as I feel which way fix is implemented might be more a matter of personal taste, but happy to submit if your prefer.

@dubstar-04
Copy link
Owner

Fixed with #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants