Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove all ...All() methods from sensors and motors #600

Open
duburcqa opened this issue Mar 21, 2023 · 1 comment
Open

[core] Remove all ...All() methods from sensors and motors #600

duburcqa opened this issue Mar 21, 2023 · 1 comment
Labels
core enhancement New feature or request P1 Mid priority issue
Projects

Comments

@duburcqa
Copy link
Owner

duburcqa commented Mar 21, 2023

The data holders (SensorSharedDataHolder_t ...) should be refactored to be actual classes managing set of sensors, and as such, being friend of the corresponding abstract class (AbstractSensorBase ...). It should provide methods operating on all sensors in the holder at once (get, setOptions ...) and being renamed accordingly (SensorManager ...).

@duburcqa duburcqa added enhancement New feature or request core P2 Low priority issue P1 Mid priority issue and removed P2 Low priority issue labels Aug 10, 2023
@duburcqa duburcqa added this to To do in Jiminy 1.8 via automation Aug 10, 2023
@duburcqa duburcqa changed the title [core] Remove all ...All() methods from sensors and motors. [core] Remove all ...All() methods from sensors and motors Oct 9, 2023
@duburcqa
Copy link
Owner Author

duburcqa commented Feb 2, 2024

Ideally, it should be possible to instantiate standalone sensors without shared storage, then update and fetch sensor measurement in isolation. The manager should only be helper that provides a bunch of optimised routines to process a ground a consistent sensors at once. It should not have to rely on private methods. It would be nice if the said manager could be completely independent from the shared storage but it actually comes together since it only makes sense if shared storage is enabled in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request P1 Mid priority issue
Projects
Status: To do
Development

No branches or pull requests

1 participant