Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't run tests that invoke re2 by default #127

Merged
merged 2 commits into from Mar 27, 2024
Merged

fix: Don't run tests that invoke re2 by default #127

merged 2 commits into from Mar 27, 2024

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented Mar 24, 2024

Closes #121.

@krlmlr
Copy link
Collaborator Author

krlmlr commented Mar 24, 2024

Also checking with rhub2 in https://github.com/duckdb/duckdb-r/actions/runs/8410717718.

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (5257514) to head (572feb4).

❗ Current head 572feb4 differs from pull request most recent head 6bb56e4. Consider uploading reports for the commit 6bb56e4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   86.28%   84.53%   -1.76%     
==========================================
  Files         107      107              
  Lines        3712     3712              
==========================================
- Hits         3203     3138      -65     
- Misses        509      574      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krlmlr
Copy link
Collaborator Author

krlmlr commented Mar 24, 2024

@krlmlr krlmlr merged commit 885c29f into main Mar 27, 2024
34 of 39 checks passed
@krlmlr krlmlr deleted the b-121-re2 branch March 27, 2024 16:21
@krlmlr
Copy link
Collaborator Author

krlmlr commented Mar 27, 2024

valgrind is green, yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use RE2 on CRAN
2 participants