Reexport all of DBI

[krlmlr]

Ideally we can use dbGetQuery() directly after loading duckdb. I wonder why the DBItest tests don't catch this.

library(duckdb)
dd <- data.frame(a = 1.5, b = "b")

con <- dbConnect(duckdb())
dbWriteTable(con, "dd", dd)

dbGetQuery(con, "SELECT round(a)")
#> Error in dbGetQuery(con, "SELECT round(a)"): could not find function "dbGetQuery"

dbGetQuery(con, "SELECT round(b)")
#> Error in dbGetQuery(con, "SELECT round(b)"): could not find function "dbGetQuery"

^{Created on 2020-01-04 by the reprex package (v0.3.0)}

[hannes]

Good point, I always only load DBI and not duckdb. How would i go about re-exporting DBI? Can you send a PR perhaps?

[jimhester]

I really don't think re-exporting the entire namespace is a good idea, this is what Depends is for...

[hannes]

@jmhester indeed that is the correct solution. Thanks for pointing this out! I have created a PR and will merge if no issues appear #411

[hannes]

@krlmlr
Perhaps DBItest could then check for that accordingly, right now I get

── 1. Failure: DBItest[duckdb]: Getting started: package_dependencies (@spec-get
3207"DBI" %in% pkg_imports isn't true.

So adding it into both Depends and Imports.

[krlmlr]

I'm not sure you can add to both Depends and Imports. Reexporting feels slightly neater than "Depends", and allows downstream packages to import only {duckdb} instead of both {duckdb} and {DBI}.

On the flip side, I see that "Depends" will make all methods (even new ones) available when users use library(duckdb), and is much less effort for the DBI driver. I'm not sure we need to update {DBItest} right away, let's keep this in mind.