Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNORE_WARNINGS flag in extension build in CMake is not handled correctly #4392

Closed
Mytherin opened this issue Aug 15, 2022 · 1 comment
Closed
Assignees

Comments

@Mytherin
Copy link
Collaborator

There is a typo in the definition:

set(INGORE_WARNINGS OFF)
build_loadable_extension(json ${JSON_EXTENSION_FILES} ${IGNORE_WARNINGS})

This causes the flag to be empty, and because CMake is CMake it does not crash on an unknown variable but instead passes in an empty string. It is also passed in as a source file (as the build_loadable_extension is a varargs function that uses everything after the extension name as a source file), so fixing the typo breaks the build as well.

@omo
Copy link
Contributor

omo commented May 11, 2023

(Unsolicited triage) Can be closed now by #4866 ? @pdet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants