Bad types in Python relational API

[davetapley]

What happens?

count('*') (and I'm sure others) from:

• Python Relational Api - Methods #2000

fail to type check with:

Arguments missing for parameters "groups", "window_spec", "projected_columns"

Pylance[reportGeneralTypeIssues]

(https://github.com/microsoft/pyright/blob/main/docs/configuration.md#reportGeneralTypeIssues)

To Reproduce

import duckdb
con = duckdb.connect()
con.sql('select 1').count('*')

You can also manually verify no defaults in method signature:

duckdb/tools/pythonpkg/duckdb-stubs/__init__.pyi

Line 353 in 6545a55

def count(self, column: str, groups: str, window_spec: str, projected_columns: str) -> DuckDBPyRelation: ...

OS:

Windows

DuckDB Version:

0.9.0

DuckDB Client:

Python

Full Name:

Dave Tapley

Affiliation:

JE Fuller

Have you tried this on the latest main branch?

I have tested with a main build

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

• Yes, I have

[davetapley]

Can use .aggregate('count(*)') as a workaround.

[Tishj]

Thanks, this change was made by an outside contributor, dealing with this is tricky because it needs to be changed in 4 places, so things like this slip through the cracks