LINESTRING EMPTY crashes duckdb spatial.

[cuteDen-ECNU]

Hi, the following statement crashes duckdb spatial.

SELECT ST_PointOnSurface(ST_Collect([ST_GeomFromText('LINESTRING(0 0, 1 1)'), ST_GeomFromText('LINESTRING EMPTY')]))
--Segmentation fault (core dumped)

Using the function ST_AsText, I got the following result.

SELECT ST_AsText(ST_Collect([ST_GeomFromText('LINESTRING(0 0, 1 1)'), ST_GeomFromText('LINESTRING EMPTY')]))
-- [('MULTILINESTRING ((0 0, 1 1), ())',)]

Version:

The result of "pragma version;" is [('v0.9.2', '3c695d7ba9')]

I used "FORCE INSTALL spatial FROM 'http://nightly-extensions.duckdb.org';" in the Python client.

[Maxxen]

Hi! Thanks for reporting this issue! Testing with PostGIS it seems to crash there too!
Thankfully the fix is easy, we just need to check if the geometry is empty before we push it to the collection here:

duckdb_spatial/spatial/src/spatial/core/functions/scalar/st_collect.cpp

Lines 32 to 34 in d3f5332

	auto geometry = lstate.factory.Deserialize(geometry_blob);
	geometries.push_back(geometry);
	}

Will include a fix next push!