Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

head(-1) #131

Closed
krlmlr opened this issue Apr 2, 2024 · 1 comment · Fixed by #156
Closed

head(-1) #131

krlmlr opened this issue Apr 2, 2024 · 1 comment · Fixed by #156
Labels
bug an unexpected problem or unintended behavior

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Apr 2, 2024

data.frame(a = 1:5) |>
  duckplyr::as_duckplyr_df() |>
  head(-2)
#> materializing:
#> ---------------------
#> --- Relation Tree ---
#> ---------------------
#> Limit -2
#>   r_dataframe_scan(0x12b3f74f0)
#> 
#> ---------------------
#> -- Result Columns  --
#> ---------------------
#> - a (INTEGER)
#> 
#>   a
#> 1 1
#> 2 2
#> 3 3
#> 4 4
#> 5 5

data.frame(a = 1:5) |>
  head(-2)
#>   a
#> 1 1
#> 2 2
#> 3 3

Created on 2024-04-02 with reprex v2.1.0

@krlmlr krlmlr added the bug an unexpected problem or unintended behavior label Apr 2, 2024
@krlmlr
Copy link
Collaborator Author

krlmlr commented Apr 2, 2024

Are we actually doing the right thing in head() ? Because this is used in tibble printing, perhaps we want to materialize the full result here and do the head() ourselves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant