Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add widget to home screen button doesn't work #1268

Closed
ghost opened this issue Jun 3, 2021 · 16 comments
Closed

Add widget to home screen button doesn't work #1268

ghost opened this issue Jun 3, 2021 · 16 comments

Comments

@ghost
Copy link

ghost commented Jun 3, 2021

Describe the bug
The pop up at the bottom of screen asks to add search widget to home screen.
On clicking the blue button, it doesn't respond.

How to Reproduce
Steps to reproduce the behavior:

  1. Freshly install the app or clear all data (user + cache)
  2. Do the first ddg search
  3. Do first url visit on other tab
  4. Click fire button and when new tab is open the pop up appears
  5. Click on the blue button 'ADD WIDGET'
  6. See the button doesn't respond, but the 'DISMISS' button works

Expected behavior
It should have added a search widget on the home screen

Smartphone (please complete the following information):

  • DDG App Version: ....
  • Device: ...
  • OS: ...
  • Screenshots:
@cmonfortep
Copy link
Contributor

We can't reproduce this issue. what happens if you add the widget manually? does that work?

@jayesh-srivastava
Copy link

@Lalisfeed Hi, can I work on this issue, if it's still available?

@cmonfortep
Copy link
Contributor

@jayesh-srivastava can you reproduce it on your device?

@jayesh-srivastava
Copy link

@jayesh-srivastava can you reproduce it on your device?

Trying to reproduce it in the emulator.

@jayesh-srivastava
Copy link

Hey @cmonfortep I just reproduced it on my emulator.

@cmonfortep
Copy link
Contributor

Thanks @jayesh-srivastava. Could you briefly explain what's the issue? I wonder why I'm not able to reproduce it on my device.

@jayesh-srivastava
Copy link

Yes sure. You need to add one directory(src) inside the bloom_cpp directory (Android\app\src\main\cpp\third-party\bloom_cpp) and inside that directory you need to add two files (BloomFilter.cpp and BloomFilter.hpp). The links of these two files are as follows:-
https://github.com/duckduckgo/bloom_cpp/blob/54e581a490236ebc3498e50db37e050cbc61923c/src/BloomFilter.cpp
https://github.com/duckduckgo/bloom_cpp/blob/54e581a490236ebc3498e50db37e050cbc61923c/src/BloomFilter.hpp

I added these two files and the directory, and the application was built in my emulator.

@jayesh-srivastava
Copy link

@cmonfortep (forgot to mention you in the previous comment so doing it here.)

@cmonfortep
Copy link
Contributor

Thanks, @jayesh-srivastava, bloom_cpp seems to be unrelated to the Widget issue.

When using your emulator, do you also have the same problem as @Lalisfeed? if so, have you been able to find the root cause of that issue?

@jayesh-srivastava
Copy link

jayesh-srivastava commented Jun 7, 2021

Hey, @cmonfortep I used the application on my emulator and it's working fine. I used the widget feature and it's working totally fine. The widget was added in the search bar.
For reference I'm adding the screenshot of my emulator:-

@jayesh-srivastava
Copy link

@Lalisfeed yes, inside the application.

@jayesh-srivastava
Copy link

@Lalisfeed Adding the screenshot here for your reference:-

No it did not ask for any special permissions. No haven't tried it on my phone, will do.

@jayesh-srivastava
Copy link

@Lalisfeed I tested it on the phone itself with app version (5.87.0) and it's working. I used the code cloned from the github repo to test the app on my mobile phone. Maybe you'll have to add the DuckDuckGo widget on your home screen.

@cmonfortep
Copy link
Contributor

If we can't reproduce it, let's close it. Thanks.

@jayesh-srivastava
Copy link

Yes @cmonfortep there wasn't an issue as such. Because it worked on my system and phone.

@Solosmoker
Copy link

I can't seem to get to work on Android tablet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants