Fix ExceptionRulesDebugReceiverRegister risk to clear the exclusion list rules #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
aitorvs
force-pushed
the
fix/aitor/atp/exception_rules_debug_receiver
branch
from
28d391b
to
cfcca51
Compare
aitorvs
force-pushed
the
fix/aitor/atp/exception_rules_debug_receiver
branch
from
cfcca51
to
9cf10d4
Compare
nshuba
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1203536459696139/f
Description
Fix bug where the receiver may clear the exception rules on VPN start
Steps to test this PR
Code review. Reproing may be difficult or involved modifying code to test it, as this would happen only when the DB table is not yet populated