Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests #333

Open
muodov opened this issue Jan 5, 2024 · 0 comments
Open

Unit tests #333

muodov opened this issue Jan 5, 2024 · 0 comments
Labels
tests Add or improve existing tests

Comments

@muodov
Copy link
Member

muodov commented Jan 5, 2024

Some parts of the code are complex enough that they can benefit from unit testing (as opposed to e2e tests that verify rules). For example, internal logic of handling multiple CMPs, or prioritizing non-cosmetic rules.
We have something resembling unit tests for rule executors, but it's hacky and not extensible.

First thing that comes to mind is using karma, but we can consider other frameworks as well.
@muodov muodov added the tests Add or improve existing tests label Jan 5, 2024
This was referenced Jan 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Add or improve existing tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@muodov