Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Privacy Dashboard related pixels #1425

Merged
merged 4 commits into from Jan 3, 2023
Merged

Conversation

miasma13
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1203568774648452/f

Description:
Fix Privacy Dashboard related pixels. Some of them become obsolete others were not fired in the new implementation.

Pixels removed:

  • privacyDashboardScorecard
  • privacyDashboardEncryption
  • privacyDashboardNetworks
  • privacyDashboardPrivacyPractices
  • privacyDashboardGlobalStats
  • privacyDashboardManageProtection

Pixels reintroduced:

  • privacyDashboardProtectionDisabled
  • privacyDashboardProtectionEnabled
  • privacyDashboardReportBrokenSite

Steps to test this PR:

  1. Check if removed pixels are no longer used.
  2. Check if reintroduced pixel are fired correctly.

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@amddg44 amddg44 self-assigned this Dec 20, 2022
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miasma13 miasma13 merged commit 2f1f3d4 into develop Jan 3, 2023
@miasma13 miasma13 deleted the michal/missing-pd-pixel branch January 3, 2023 15:21
bershanskiy pushed a commit to bershanskiy/duckduckgo-iOS that referenced this pull request Jan 13, 2023
Task/Issue URL: https://app.asana.com/0/414235014887631/1203568774648452/f

Description:
Fix Privacy Dashboard related pixels. Some of them become obsolete others were not fired in the new implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants