Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreGraphics create_protected_copy crash fix attempt #1427

Merged
merged 1 commit into from Jan 27, 2023

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Dec 23, 2022

Task/Issue URL: https://app.asana.com/0/414709148257752/1203075050360165/f
Tech Design URL:
CC:

Description:
Attempt to fix crash by removing a force unwrap

Steps to test this PR:

  1. Visit a webpage with js alerts e.g. https://privacy-test-pages.glitch.me/features/js-alerts.html
  2. With a js alert tab showing, tap the tab switcher and confirm the js alert is snapshotted and displayed correctly in the tab preview

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@amddg44 amddg44 merged commit fbfdf7f into develop Jan 27, 2023
@amddg44 amddg44 deleted the anya/fix-coregraphics-crash branch January 27, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants