More updates to duckpan new

[moollaza]

thanks to @mwmiller for the feedback

cc// @mwmiller

also @killerfish I made a new fn to check the current directory, get they type of IA we're working with and error out if it's Longtail or Fathead

Would appreciate any feedback :)

Note this has two accompanying change to the Spice and Goodie templates

• update template to meet new DuckPAN changes zeroclickinfo-spice#1185
• update Goodies template to meet new DuckPAN changes zeroclickinfo-goodies#700

[killerfish]

Best, i was about to add this and send a pr, i was thinking something like this, i think the 0/1 may be a better indicator to someone scanning the code, of what we are supporting now, perhaps. So in future, if we have to support some ia, we just set the value to 1. @mwmiller what you say?

[mwmiller]

@moollaza @killerfish Here is my even crazier take on how to organize the data. I've got some of each of your ideas in here. That array of hashrefs very much wants to become an array of objects, but that will be for another day, if ever.

[killerfish]

Its perfect, i was also thinking along the lines to make this an attribute, but didnt see the use for that, cleanup of New.pm justifies it for me.

[mwmiller]

@killerfish I think it's a ways from "perfect", but I thank you for the kind words. 😁

Regardless, I also have this as a suggested first step towards more sane logging. I don't want to open a PR until it become clear how these branches will come together, because many of the places where the improved logging gets used are in flux.

[killerfish]

@mwmiller true, can we merge this one, so i can update #138 and we close #138 and #139. Also lmk your thoughts on this in case you use codio.

[moollaza]

@mwmiller your approach is awesome. Let's do it :)

[mwmiller]

@moollaza @killerfish I've merged in the two mentioned branches (the data reorg and the exit_with_msg stuff.) I tested all of the happy paths and the obvious unhappy paths, but there might still be things lurking, so extra eyes appreciated.

[moollaza]

Tested a bunch in different repos. Only fix I'd like to make is that DuckPAN server still runs for Fathead as expected and then fails hard after making a request. This is unrealted to this code, but can be alleviated by utilizing the new functionality :)