This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Enable utf8 flag in duckpan query #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing duckduckgo/zeroclickinfo-goodies#1264 I noticed some odd behaviour in DuckPAN when dealing with UTF8 chars in the regexs. When the regexes contain unicode chars (like 4 ÷ 2) and
use utf8was not present, the IA did not work in DuckPAN Query but did in DuckPAN Server.After seeing that DuckPAN Serve turns on the utf8 flag before passing the raw query to
DDG::RequestI tried that in DuckPAN Query and everything works as expected!/cc @zachthompson