This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Introduce caching for page assets (js/css) #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. No more hardocoded js/css calls
|
**Note: In order to test this, you'll also need to deploy the core changes (https://dub.duckduckgo.com/core/ddg/pull/261) to your dev instance and make sure duckpan is pulling from your instance. |
| if (my $src = $_->attr('src')) { | ||
| if ($src =~ m/^\/(d\d{4}\.js)/) { | ||
| $page_js_filename = $1; | ||
| } elsif ($src =~ m/^\/spice2\/(spice2_duckpan_\d{1,3}\.js)/) { |
|
Please add some explanatory inline comments. |
|
ping. This needs to be reviewed and merged asap. We've already merged the accompanying changes on Core (weeks ago...), so now versioned files are being provided, but DuckPAN is still grabbing the old, stale, unversioned files (i.e. d.js, s.css and spice2_duckpan.js) by requesting them directly from DDG. |
| # and stores locally in its own cache | ||
| # The are all necessary for DuckPAN Server to function properly | ||
| # | ||
| # Page_Root.html : DDG Homepage |
moollaza
added a commit
that referenced
this pull request
Oct 26, 2013
Introduce caching for page assets (js/css)
|
Merged with @yegg's approval |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc/ @nospampleasemam @yegg @russellholt
In light of https://dub.duckduckgo.com/core/ddg/pull/252#issuecomment-796
I've re-written a portion of Web.pm to now request the SERP from DDG, then find the latest version for
d####.js,s.###cssandspice2_duckpan_###.jsIf the file already exists in Duckpan's local cache, it won't request the file, otherwise it will get the newest one.
Please give feedback on my implementation -- there's room for improvement but for now this works and is a much safer way of getting the required assets.