Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Currency: The default currency should depend on the person's region #2045

Closed
waghso opened this issue Jul 17, 2015 · 8 comments
Closed

Currency: The default currency should depend on the person's region #2045

waghso opened this issue Jul 17, 2015 · 8 comments

Comments

@waghso
Copy link

waghso commented Jul 17, 2015

Hi,

I'm from India where Indian rupee(INR) is currency. When I search for $123 result shows 112.87 EUR.
This is unacceptable. I'm in India and and I only care about INR currency. This may be same for other users as well. Can you convert currency to according to Nation of user???

image


IA Page: http://duck.co/ia/view/currency

@gokul1794
Copy link
Contributor

I think this IA should check if the user has given a region and convert to that or not trigger at all on a query like this if he hasn't!

@jagtalon
Copy link
Member

The https://duck.co/duckduckhack/language_and_location_apis API could help, and this actually might be the ideal behavior. Any comments on this @moollaza @chrismorast?

@jagtalon
Copy link
Member

Or we could use the region instead by using DDG.settings.get("kad"), but this requires a requery for the new data.

@jagtalon jagtalon changed the title Currency: INR Currency: The default currency should depend on the person's region Jul 24, 2015
@MrChrisW
Copy link
Collaborator

@waghso Thanks for reporting this.

@jagtalon I'll jump on this issue. I think using the $loc var from the location API will be easiest solution.

However using JS to grab the set location may be more accurate. Quick question: does this use the same data to determine user location as the location API?

@jagtalon
Copy link
Member

@MrChrisW it actually gets the data from the region settings so this one is set by the user. :)

@moollaza
Copy link
Member

moollaza commented Aug 1, 2015

Just so everyone is aware, this IA is setup to automatically convert the input currency to the most common converted currency, for the given input currency IIRC. This way anyone who searches a USD amount will get EUR because that's the most common/popular conversion.

I think we might want to sit on this for a bit and see if we get any other complaints. So far no one else has complained and this is a pretty popular Instant Answer.

I'd like to discuss this further with the team to hear their thoughts.

@MrChrisW
Copy link
Collaborator

MrChrisW commented Aug 1, 2015

@moollaza 👍 Sounds fine! Happy Weekend btw.

@moollaza
Copy link
Member

moollaza commented Aug 4, 2015

Hey guys, so I've discussed this with the team and we came to some conclusions. Ultimately I don't think we should default to the user's location because I feel the expectation is that it will use the most common one. However, there's no need for us to only show the single most popular conversion for the input currency.

We unanimously agreed that when no input is given, we should handle it the same way we handle it when the input is "1" unit or just the name of the currency, like "usd".

So if you search "$12 usd" we should show the tiles which contain the conversions to the most common. If the user really wants to know what the value of a given currency is in a specific currency its highly likely that they'll specify both the FROM and TO currencies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants