Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

SoundCloud: No Volume Control or Skip Ahead. #2298

Closed
HarshInvader opened this issue Nov 21, 2015 · 6 comments
Closed

SoundCloud: No Volume Control or Skip Ahead. #2298

HarshInvader opened this issue Nov 21, 2015 · 6 comments

Comments

@HarshInvader
Copy link

@jdan
Having online a play-pause feature might not be enough. I many-a-times had the urge to move ahead in the song but when I tried click on the circle ahead, it paused.
And Volume Control won't be that difficult, c'mon!


IA Page: http://duck.co/ia/view/sound_cloud

@gpestana
Copy link
Collaborator

Play, pause, skip and volume would be nice features to add. SoundCloud provides those features through their API (https://developers.soundcloud.com/docs/api/html5-widget). I will try to implement it.

@MrChrisW
Copy link
Collaborator

Thanks for the suggestion @HarshInvader

@gpestana Please reach out to any of the DuckDuckGo community members for assistance or shot an email off to open@duckduckgo.com

@gpestana
Copy link
Collaborator

@MrChrisW yep, just got help from @moollaza on Slack!

I dug a bit into this issue and these are my conclusions:

  1. It doesn't seem viable to use Sound Cloud's API because it is exposed through their widget that has to be embedded somehow. This might pose privacy issues (thanks @moollaza for the heads up on this issue);
  2. Sound Cloud's IA is rendered with audio_item.handlebars, so I guess that at least pause, stop and skip can be implemented in the audio player. Though, I can't find where the player's JS code is. Maybe it's not open sourced?
  3. Based on the player's code, maybe the volume controller can be added.

Any suggestions on how we could do this? I believe it can be done and since the audio_item.handlebars template is used in more IAs (and potentially can be used further in many others), it would be a good time investment to have a nice and fully featured audio player to use on DuckDuckGo :)

@moollaza
Copy link
Member

As @gpestana has mentioned, this functionality isn't currently possible without us doing some internal work to expose the audio player's volume and tracking capabilities to the templates, and then updating the templates to allow for this.

@abeyang @bsstoner what are your thoughts on this?

I like the suggestion but I don't think this is something critical. If it's a simple fix it might be nice to have though?

@rasikapohankar
Copy link
Contributor

rasikapohankar commented Apr 21, 2016

Helloo! I was wondering if it might also be possible to add a 'Repeat Song' button? Would be great to have it!

@moollaza
Copy link
Member

moollaza commented Oct 9, 2017

Closing due to DDH entering Maintenance Mode. We are now only accepting issues for essential bugs/fixes.

@moollaza moollaza closed this as completed Oct 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants