Port non-API Spice to Goodies #2463
Comments
If you spot a Spice that should (or shouldn't) be on this list, please let me know! |
@GuiltyDolphin this is really useful! ❤️ ❤️ ❤️ |
@jagtalon I'll kick this off by porting |
@GuiltyDolphin yeaaaaaa |
I would like to take up FlashVersion. :) |
@yash14123 Sure thing! Remember to reference this issue in both PR's (and a reference to the other PR in each) when you're ready! :) |
@duckduckgo/duckduckhack-contributors we could really use a lot of help over here too. This is a fairly easy, but very important task. We didn't always have JS available to Goodies and so we have a few "Spice" Instant Answers that don't actually use APIs and they should really be converted to Goodies with JS (like the 2048 Game). There are still 4 IA's left to convert! Is anyone interested in tackling them? |
@theaverageguy are you still interested in converting FlashVersion? If so don't forget to mention this issue in your PR so everyone else knows it's been fixed! |
I'll port the stopwatch and color picker, as those are my other JS-only spices (I tend to make a bunch of those) |
You are my hero @mattr555 |
hey @mattr555 ! Are you still up for porting the color picker spice? If not I'd like to do it as my first contribution. And @GuiltyDolphin issue #2675 is pending for color picker - awaiting a better solution . so should we wait for it or can I fix that issue and port color picker together? |
@shashankgroovy I think that solution won't be necessary as we'll be processing more of the queries in the Perl so I think it would be better handled in Perl as a Goodie (though I haven't familiarized myself with the workings of that IA). What say you @mattr555 ? |
@GuiltyDolphin will the geometry and editor spices will also be rewritten in Perl as a goodie as well? |
@shashankgroovy Geometry has a PR in progress (duckduckgo/zeroclickinfo-goodies#2675); but I don't think there's anything in progress for Editor yet - you can pick it up if you wish ❤️ |
@GuiltyDolphin That'd be great. I'll take up the Editor. I will start working on it asap. |
@shashankgroovy awesome! |
@shashankgroovy Sure, feel free to ping me on Slack if you have any issues. |
@GuiltyDolphin @edgesince84 @moollaza I can start porting |
@manrajgrover yep go ahead! |
@manrajgrover I haven't spotted any - though if you see one please comment here to let me know and I can add it to the list ❤️ |
Goodies can support JS too! Any Spice that doesn't require API calls should be ported to Goodies, if you're interested, please follow the Guidelines below.
Guidelines
Choosing a Spice
Relevant Spices
list (if you have mentioned that you would like to port a Spice, but can no longer do so for any reason, please let me know so I can make it clearly available again).Porting the Spice
duckpan test
to test everything andduckpan test SPICE_NAME
(whereSPICE_NAME
is the name of the Spice being ported) to test the Spice).Uploading your changes
Port SPICE_NAME to Goodies
whereSPICE_NAME
is the name of the Spice you are porting. You should make one PR on Spice, which removes the Spice, and one on Goodies, which ports the functionality. _Please link to the PR on the other repo as well as this issue for both pull requests!_Relevant Spices
Editor
Timer
Geometry
ColorPicker
Stopwatch
FlashVersion
Reference to the Goodie issue: duckduckgo/zeroclickinfo-goodies#2258
The text was updated successfully, but these errors were encountered: