Skip to content

Flash version doesn't show the last 3 numbers. #99

Closed
zekiel opened this Issue Sep 15, 2012 · 8 comments

6 participants

@zekiel
DuckDuckGo member
zekiel commented Sep 15, 2012

DDG can tell you your flash version but it doesn't give you the last 3 numbers:

Example: On DDG: "Your Flash Player version: 11.1.102 More at Adobe".

Full version: "11.1.102.62"

Also, it would be useful to have the version table available on Adobe at: http://kb2.adobe.com/cps/155/tn_15507.html

@jagtalon
DuckDuckGo member

@zekiel Downside to this is that the user would have to download more content to get it working because we have to use some other library which we're not currently planning on using: https://code.google.com/p/swfobject/

I think we should just tolerate this. @sdougbrown @bsstoner any opinion on this?

@bsstoner

Whoa, I didn't realize we were building FlashDetect into core. Is it used for anything else besides this spice? Can we remove and just add to this spice?

You can get the full version without a lib. It's like 20-30 lines of code for cross-browser detection. Something like this in Chrome/FF: navigator.mimeTypes["application/x-shockwave-flash"].enabledPlugin It's a little more verbose in IE.

@jagtalon
DuckDuckGo member

@bsstoner Yup, we can do that too, but I thought I should take advantage of FlashDetect since it's already there. It's not used in any other Spice, and a quick grep in the core repo didn't show anything. We should probably move it out of there then.

@zekiel
DuckDuckGo member
zekiel commented Jul 21, 2014

not my area of expertise :) defaulting to your judgement

http://i.imgur.com/50iWAFW.gif

@javathunderman
DuckDuckGo member

@jagtalon @zekiel @bsstoner Seems like this can be closed then?

@moollaza
DuckDuckGo member

@javathunderman I don't think we've resolved it yet, so we should keep it open.

@MrChrisW MrChrisW self-assigned this Jan 5, 2016
@MrChrisW
DuckDuckGo member
MrChrisW commented Jan 6, 2016

Fixed in #2373

@MrChrisW MrChrisW closed this Jan 6, 2016
@javathunderman
DuckDuckGo member

@MrChrisW nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.