Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should bork download be removed? #336

Closed
duckinator opened this issue Nov 16, 2023 · 5 comments
Closed

Should bork download be removed? #336

duckinator opened this issue Nov 16, 2023 · 5 comments

Comments

@duckinator
Copy link
Owner

Basically:

  • I'm not sure I have ever used bork download aside from testing the functionality.
  • I literally don't know why I added it.
  • It adds a lot of complexity to the codebase, for very little benefit.

I'm wondering if it makes sense to remove bork download entirely, or possibly split it out into a separate tool.

@duckinator
Copy link
Owner Author

@nbraud @AstraLuma what're your thoughts on this?

@AstraLuma
Copy link
Contributor

It looks like it would be useful for artifact handling in CI? But

  1. Very few projects publish python packages in github releases--it's just easier to use PyPI
  2. I'm not sure what CI flow would involve downloading a previously-built package through non-standard channels

@duckinator
Copy link
Owner Author

That's why I'm thinking it might make sense to split it out into its own tool. It's useful, but in different situations than bork is useful.

@duckinator
Copy link
Owner Author

Independently of it being removed: as long as it exists, the definition of bork.api.DOWNLOAD_SOURCES should be moved into bork.api.download() so it doesn't affect other commands.

@duckinator
Copy link
Owner Author

Closing in favor of #357.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants