Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Buffer#readUIntLE instead of external dep #70

Closed
reviewher opened this issue Nov 23, 2021 · 1 comment
Closed

Use Buffer#readUIntLE instead of external dep #70

reviewher opened this issue Nov 23, 2021 · 1 comment

Comments

@reviewher
Copy link

Buffer#readUIntLE has been available since v0.11.15 (many years before node v12) so using the native function will not decrease support surface.

Under the hood it uses an internal readUInt24LE implementation..
@dudleycarr
Copy link
Owner

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dudleycarr @reviewher