Change span/error code of assignment failure due to wrong properties

[kdy1]

Problem

stc/crates/stc_ts_type_checker/tests/conformance/types/objectTypeLiteral/indexSignatures/stringIndexerConstrainsPropertyDeclarations2.ts

Lines 35 to 39 in 56ae129

	// error
	var b: { [x: string]: A } = {
	a: A,
	b: B
	}

Wanted: [RefError { line: 16, column: 5, code: "TS2411" }, RefError { line: 23, column: 5, code: "TS2411" }, RefError { line: 24, column: 5, code: "TS2411" }, RefError { line: 31, column: 5, code: "TS2411" }, RefError { line: 32, column: 5, code: "TS2411" }, RefError { line: 37, column: 8, code: "TS2741" }, RefError { line: 38, column: 8, code: "TS2741" }]
Unwanted: [(36, "TS2322")]

All required errors: [RefError { line: 15, column: 5, code: "TS2411" }, RefError { line: 16, column: 5, code: "TS2411" }, RefError { line: 23, column: 5, code: "TS2411" }, RefError { line: 24, column: 5, code: "TS2411" }, RefError { line: 31, column: 5, code: "TS2411" }, RefError { line: 32, column: 5, code: "TS2411" }, RefError { line: 37, column: 8, code: "TS2741" }, RefError { line: 38, column: 8, code: "TS2741" }]
All actual errors: [(15, "TS2411"), (36, "TS2322")]', crates/stc_ts_type_checker/tests/tsc.rs:742:17

We report an error on line 36. To be exact, we are reporting an assignment failure (TS2322) on VarDeclarator.

But we should report multiple TS2741 (missing properties) instead and on line 37 and 38.

Actually, we have logic for creating TS2741.

stc/crates/stc_ts_file_analyzer/src/analyzer/assign/type_el.rs

Lines 778 to 783 in 56ae129

	if !missing_fields.is_empty() {
	errors.push(Error::MissingFields {
	span,
	fields: missing_fields,
	});
	}

But because tsc uses TS2322 for many kinds of missing properties, we have extra logic for converting it to TS2322.
We should change it not to use such logic for assignments to index signatures

Solution

We should preserve MissingFields in more cases and call nested assign with the span of properties in the RHS of assignments.

Note

This issue is hard to fix I guess

[kdy1]

Closing as postponed. See #768