Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs updating to use CRC16 instead of checksum #4

Open
dc42 opened this issue Oct 31, 2023 · 0 comments
Open

Needs updating to use CRC16 instead of checksum #4

dc42 opened this issue Oct 31, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@dc42
Copy link
Contributor

dc42 commented Oct 31, 2023 •
edited
Loading

The current version is not compatible with PanelDue firmware versions that use a CRC16 instead of a checksum at the end of each command sent.

I have added tag last-release-using-checksums on the latest commit, for the benefit of anyone staying with RRF/PanelDueFirmware versions prior to 3.4. I suggest we amend this firmware to support only CRC16 from PanelDue, and to generate CRC16 when sending commands to the Duet. It would be possible to recognise checksums from PanelDue too (see the code in RRF for how to do this) but I think there is little point in doing this.
@dc42 dc42 added the bug Something isn't working label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dc42