Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'fileId' member of GCodeMachineState not being set by M98 command from DWC #13

Closed
dc42 opened this issue Jul 2, 2019 · 2 comments
Closed

'fileId' member of GCodeMachineState not being set by M98 command from DWC #13

dc42 opened this issue Jul 2, 2019 · 2 comments

Comments

@dc42
Copy link

dc42 commented Jul 2, 2019

If a M98 command is issued from USB then the fileId member of GCodeMachineState gets set. However, if the M98 command is sent form the GCodeConsole in DWC then the fileId member is not set. In consequence, GCodeBuffer::IsDoingFile() incorrectly returns false.
@dc42
Copy link
Author

dc42 commented Jul 2, 2019

See also issue #1

@chrishamm
Copy link
Contributor

Fixed in the latest DCS version because it no longer interprets M98 independently from RRF. Instead, it lets M98 invoke a nested macro which ensures this flag is set correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dc42 @chrishamm