-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new required columns #59
Comments
Out of curiosity, what are these new columns? |
I haven’t gone through all of the tabs yet, but all columns are listed in the spreadsheet above. Once I piece them out, I’d welcome feedback. |
Here are the new columns that were added with the first new completed book.
|
I've actually got a bunch of this data in a spreadsheet already (or in json if that's easier), but we'd probably need some kind of script to insert it into all our yaml files. Spreadsheet is here: https://docs.google.com/spreadsheets/d/1tzjeYPZtdbolNlhsBSHIcLDzEDHvsPscozCMQ9Gfi60/edit?usp=sharing I can send the json file if needed, though it's currently got basically all of the data that's in that spreadsheet in a single ~700KB file (splitting that was on my todo list before this project popped up). We'd also have to just match by name and hope they're close enough without duplicates to handle 99% of cases. That said, I do also have some more descriptive data in there that we could use if it's something we want. Depending on what it is, it's either excerpts from the books or my own interpretation of it (written for people who were definitely not as into star wars as I was :P) |
Nice! Yeah, I would be a bit concerned matching on the names, but I suppose we could give it a shot and see where it shakes out. |
Whatever script is written to handle this could probably just look for a case-insensitive match, and if it finds a single one, do the update, otherwise just write out a message saying what couldn't be matched. Hopefully that would take care of most, and would only need minor amounts of manual adjusting. |
This is being done as I add data for CotR in #88. After I’m done with that first new book, we should have all of the necessary columns ready. |
Our first community member has finished entering content for a book! Rise of the Separatists! Thank you P-47 Thunderbolt from the FFG formums!
Here's the spreadsheet: https://docs.google.com/spreadsheets/d/1FgGOmFdgbqTx8l4HVCT0huPdtztDUfzaZB04ur-SB6M/edit#gid=2094253977
After some discussion, we decided to include some additional columns. That means we need to add these additional columns to the already existing data.
The text was updated successfully, but these errors were encountered: