Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new required columns #59

Closed
duffn opened this issue Feb 23, 2020 · 7 comments
Closed

Add new required columns #59

duffn opened this issue Feb 23, 2020 · 7 comments
Labels
data Pertaining to data creation or auditing enhancement New feature or request

Comments

@duffn
Copy link
Owner

duffn commented Feb 23, 2020

Our first community member has finished entering content for a book! Rise of the Separatists! Thank you P-47 Thunderbolt from the FFG formums!

Here's the spreadsheet: https://docs.google.com/spreadsheets/d/1FgGOmFdgbqTx8l4HVCT0huPdtztDUfzaZB04ur-SB6M/edit#gid=2094253977

After some discussion, we decided to include some additional columns. That means we need to add these additional columns to the already existing data.

  • Review the spreadsheet and the already existing data
  • Add the new columns where necessary
@duffn duffn added enhancement New feature or request good first issue Good for newcomers data Pertaining to data creation or auditing labels Feb 23, 2020
@bknowles
Copy link

Out of curiosity, what are these new columns?

@duffn
Copy link
Owner Author

duffn commented Feb 23, 2020

I haven’t gone through all of the tabs yet, but all columns are listed in the spreadsheet above.

Once I piece them out, I’d welcome feedback.

@duffn
Copy link
Owner Author

duffn commented Feb 24, 2020

Here are the new columns that were added with the first new completed book.

Resource Column
Species WT
Species ST
Species Br
Species Ag
Species Int
Species Cun
Species Will
Species Pr
Species XP
Species Special Abilities
Vehicles Armor
Vehicles HTT
Vehicles STT
Vehicles Defense
Vehicles Sensors
Starships Armor
Starships HTT
Starships STT
Starships Defense
Starships Sensors
Adversaries Soak
Adversaries WT
Adversaries ST
Adversaries M/R Defense
Adversaries Br
Adversaries Ag
Adversaries Int
Adversaries Cun
Adversaries Will
Adversaries Pr

@AndreLemay
Copy link
Collaborator

I've actually got a bunch of this data in a spreadsheet already (or in json if that's easier), but we'd probably need some kind of script to insert it into all our yaml files.

Spreadsheet is here: https://docs.google.com/spreadsheets/d/1tzjeYPZtdbolNlhsBSHIcLDzEDHvsPscozCMQ9Gfi60/edit?usp=sharing

I can send the json file if needed, though it's currently got basically all of the data that's in that spreadsheet in a single ~700KB file (splitting that was on my todo list before this project popped up).

We'd also have to just match by name and hope they're close enough without duplicates to handle 99% of cases. That said, I do also have some more descriptive data in there that we could use if it's something we want. Depending on what it is, it's either excerpts from the books or my own interpretation of it (written for people who were definitely not as into star wars as I was :P)

@duffn
Copy link
Owner Author

duffn commented Feb 26, 2020

Nice!

Yeah, I would be a bit concerned matching on the names, but I suppose we could give it a shot and see where it shakes out.

@AndreLemay
Copy link
Collaborator

Whatever script is written to handle this could probably just look for a case-insensitive match, and if it finds a single one, do the update, otherwise just write out a message saying what couldn't be matched. Hopefully that would take care of most, and would only need minor amounts of manual adjusting.

@duffn duffn removed the good first issue Good for newcomers label Feb 26, 2020
@duffn duffn added this to To do in The Outer Rim Feb 26, 2020
@duffn
Copy link
Owner Author

duffn commented Mar 7, 2020

This is being done as I add data for CotR in #88. After I’m done with that first new book, we should have all of the necessary columns ready.

@duffn duffn closed this as completed Mar 7, 2020
The Outer Rim automation moved this from To do to Done Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Pertaining to data creation or auditing enhancement New feature or request
Projects
No open projects
The Outer Rim
  
Done
Development

No branches or pull requests

3 participants