Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which branch should I submit to? #190

Closed
cannian1 opened this issue Feb 28, 2024 · 3 comments
Closed

Which branch should I submit to? #190

cannian1 opened this issue Feb 28, 2024 · 3 comments

Comments

@cannian1
Copy link
Collaborator

In contributing-guide, It mentioned to submit to the v2 branch.

But the v2 branch doesn't have GitHub Actions.

Like #145 , PR may fail in test.

@duke-git
Copy link
Owner

duke-git commented Feb 28, 2024

In contributing-guide, It mentioned to submit to the v2 branch.

But the v2 branch doesn't have GitHub Actions.

Like #145 , PR may fail in test.

Yes, the current branch management is not standardized. To solve this problem, I suggest creating a release candidate (rc) branch to release the next version lib. All PRs should request be merged into the RC branch. At the same time, the rc branch uses GitHub Actions to run unit test tasks. After release, the rc branch will be merged into the main branch.

@cannian1
Copy link
Collaborator Author

I think this is feasible, so when would be a good time to start?

Does anyone have any other suggestions?

@duke-git
Copy link
Owner

I think this is feasible, so when would be a good time to start?

Does anyone have any other suggestions?

I created the rc branch for release candidate. All PRs should be merged into the rc branch. The main branch will be frozen.

@duke-git duke-git closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants