Fix Duplicated Refresh Bug

files-community · May 11, 2019 · 228b462 · 228b462
1 parent a111058
commit 228b462
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 14 deletions.
diff --git a/ExecutableLauncher/Program.cs b/ExecutableLauncher/Program.cs
@@ -13,9 +13,11 @@ private static void Main(string[] args)
                 var executable = (string)ApplicationData.Current.LocalSettings.Values["Application"];
                 Process.Start(executable);
             }
-            catch (Exception e)
+            catch (System.ComponentModel.Win32Exception e)
             {
+                Console.WriteLine("While most executables work now, UWP restrictions still prevent the execution of this file");
                 Console.WriteLine(e.Message);
+                Console.WriteLine(e.StackTrace);
                 Console.ReadLine();
             }
         }

diff --git a/Files UWP/Filesystem/ItemViewModel.cs b/Files UWP/Filesystem/ItemViewModel.cs
@@ -215,16 +215,8 @@ public async void AddItemsToCollectionAsync(string path, Page currentPage)
 
             _cancellationTokenSource = new CancellationTokenSource();
 
-            if (typeof(PageType) == typeof(GenericFileBrowser))
-            {
-                (currentPage as GenericFileBrowser).emptyTextGFB.Visibility = Visibility.Collapsed;
-                _filesAndFolders.Clear();
-            }
-            else if (typeof(PageType) == typeof(PhotoAlbum))
-            {
-                (currentPage as PhotoAlbum).EmptyTextPA.Visibility = Visibility.Collapsed;
-                _filesAndFolders.Clear();
-            }
+            GetCurrentSelectedTabInstance<ProHome>().TextState.isVisible = Visibility.Collapsed;
+            _filesAndFolders.Clear();
             Universal.path = path;
 
             Stopwatch stopwatch = new Stopwatch();

diff --git a/Files UWP/GenericFileBrowser.xaml.cs b/Files UWP/GenericFileBrowser.xaml.cs
@@ -105,7 +105,6 @@ protected override void OnNavigatedTo(NavigationEventArgs eventArgs)
             var parameters = (string)eventArgs.Parameter;
             instanceViewModel.CancelLoadAndClearFiles();
             instanceViewModel.Universal.path = parameters;
-            CurrentInstance.RefreshButton.Click += NavigationActions.Refresh_Click;
             CurrentInstance.AddItemButton.Click += AddItem_Click;
             instanceViewModel.AddItemsToCollectionAsync(instanceViewModel.Universal.path, this);
             TextState_PropertyChanged(null, null);

diff --git a/Files UWP/ProHome.xaml.cs b/Files UWP/ProHome.xaml.cs
@@ -89,6 +89,7 @@ public ProHome()
             PopulateNavViewWithExternalDrives();
             BackButton.Click += NavigationActions.Back_Click;
             ForwardButton.Click += NavigationActions.Forward_Click;
+            RefreshButton.Click += NavigationActions.Refresh_Click;
             ribbonShadow.Receivers.Add(RibbonShadowSurface);
             Ribbon.Translation += new System.Numerics.Vector3(0, 0, 4);
 
@@ -806,14 +807,12 @@ public async static void Refresh_Click(object sender, RoutedEventArgs e)
                 {
                     var ContentOwnedViewModelInstance = (ItemViewModel<ProHome>.GetCurrentSelectedTabInstance<ProHome>().accessibleContentFrame.Content as GenericFileBrowser).instanceViewModel;
                     ContentOwnedViewModelInstance.CancelLoadAndClearFiles();
-                    (ItemViewModel<ProHome>.GetCurrentSelectedTabInstance<ProHome>().accessibleContentFrame.Content as GenericFileBrowser).emptyTextGFB.Visibility = Visibility.Collapsed;
                     ContentOwnedViewModelInstance.AddItemsToCollectionAsync(ContentOwnedViewModelInstance.Universal.path, (ItemViewModel<ProHome>.GetCurrentSelectedTabInstance<ProHome>().accessibleContentFrame.Content as GenericFileBrowser).GFBPageName);
                 }
                 else if ((ItemViewModel<ProHome>.GetCurrentSelectedTabInstance<ProHome>().accessibleContentFrame.Content as PhotoAlbum) != null)
                 {
                     var ContentOwnedViewModelInstance = (ItemViewModel<ProHome>.GetCurrentSelectedTabInstance<ProHome>().accessibleContentFrame.Content as PhotoAlbum).instanceViewModel;
                     ContentOwnedViewModelInstance.CancelLoadAndClearFiles();
-                    (ItemViewModel<ProHome>.GetCurrentSelectedTabInstance<ProHome>().accessibleContentFrame.Content as PhotoAlbum).EmptyTextPA.Visibility = Visibility.Collapsed;
                     ContentOwnedViewModelInstance.AddItemsToCollectionAsync(ContentOwnedViewModelInstance.Universal.path, (ItemViewModel<ProHome>.GetCurrentSelectedTabInstance<ProHome>().accessibleContentFrame.Content as PhotoAlbum).PAPageName);
                 }