Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for error messages #83

Closed
chauhanprateek89 opened this issue Mar 13, 2022 · 7 comments
Closed

Support for error messages #83

chauhanprateek89 opened this issue Mar 13, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@chauhanprateek89
Copy link

Currently errors like "divide by zero" gives out message as "infinity".

There is potential here to expand on this, like -
"Bhai ye kya kiya"
"Bhai aise nahi hota"
"Bhai ye kya kar diya"

@ristri ristri added the enhancement New feature or request label Mar 13, 2022
@Deep-Codes
Copy link
Contributor

Would work on this

What should be an idea message?

thinking of Bhai Bhai Bhai...

wdyt?

@chauhanprateek89
Copy link
Author

Bhai Bhai Bhai could serve as a good starting point as a generic error message instead of "infinity". We can then lean towards more custom messages as we move forward.
What's your take?

@Deep-Codes
Copy link
Contributor

Bhai Bhai Bhai could serve as a good starting point as a generic error message instead of "infinity". We can then lean towards more custom messages as we move forward. What's your take?

Check out the PR have added ^

Screenshot 2022-03-13 at 6 12 58 PM

@chaidosa
Copy link

Suggestion:
Hey error message could be bhai ye kya kar rha hai tu!!

@chauhanprateek89
Copy link
Author

We should be gender-neutral with how we design this as we want maximum adaptation. Just a thought.

@Kadam-Tushar
Copy link

Another suggestion:
Bhai kya kar raha hai tu?

@aniketsingh0104
Copy link
Member

Already Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants