Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve icons in editing mode #189

Open
766F6964 opened this issue May 26, 2024 · 3 comments
Open

Improve icons in editing mode #189

766F6964 opened this issue May 26, 2024 · 3 comments
Labels
suggestion An enhancement that may be considered in the future

Comments

@766F6964
Copy link

766F6964 commented May 26, 2024

I noticed that the icons in the markdown editing mode are slightly blurry.
This is especially noticable when zoomed in.
Below is an example with high zoom level to illustrate this:

Screenshot from 2024-05-27 01-34-50

Screenshot from 2024-05-27 01-39-11

It is worth noting, that icons in e.g. the main menu in the top right corner don't have this problem.
I think it would make sense to replace this icons with .svg icons to have them sharp on any zoom level.
Additionally, this might be a good opportunity to go for a uniform icon style in the application.

@dullage
Copy link
Owner

dullage commented May 28, 2024

Unfortunately these icons are part of the 3rd party (Toast UI) markdown editor that flatnotes uses and therefore are not easily replaced.

Really I'd like to replace the entire toolbar to something more in keeping with the rest of the app but that would be a bigger job.

@dullage dullage added the suggestion An enhancement that may be considered in the future label May 30, 2024
@clach04
Copy link

clach04 commented Jun 2, 2024

@dullage is there value in @766F6964 opening an issue upstream https://github.com/nhn/tui.editor ?

@dullage
Copy link
Owner

dullage commented Jun 4, 2024

@clach04 - I don't think so. The editor may even allow me to build my own toolbar already, but I haven't looked through the docs recently.

To be honest, rather than doubling down on the Toast Editor, if I were to change anything I'm more likely to look at other options. Something headless with good maintenance. Project for the future though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion An enhancement that may be considered in the future
Projects
None yet
Development

No branches or pull requests

3 participants