Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum call stack size exceeded #45

Closed
mnasyrov opened this issue Jun 9, 2020 · 3 comments
Closed

Maximum call stack size exceeded #45

mnasyrov opened this issue Jun 9, 2020 · 3 comments

Comments

@mnasyrov
Copy link

mnasyrov commented Jun 9, 2020

Hello!

I've got this error during testing a plugin for Dexie.js with FakeIndexedDB, more details about a context here: dexie/Dexie.js#1053

Error output:

RangeError: Maximum call stack size exceeded

    at FDBTransaction.Object.<anonymous>.FDBTransaction._start

If I comment out the following lines in FDBTransaction.js, it works (or seems like working):

            // On to the next one
            // if (this._requests.length > 0) {
            //     this._start();
            // }
            // else {
                // Give it another chance for new handlers to be set before finishing
                setImmediate(this._start.bind(this));
            // }
@dumbmatter
Copy link
Owner

Thanks for looking into the bug! All the test still pass with your proposed change. And I don't remember why I had those two different ways of calling this._start, so maybe there was no good reason in the first place.

@dumbmatter
Copy link
Owner

Fixed in v3.0.2. Thanks again!

@mnasyrov
Copy link
Author

Thank you for the fix, it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants