Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

[Bug] Different files use different end-of-line encodings #75

Closed
walshawi opened this issue Jan 8, 2020 · 1 comment
Closed

[Bug] Different files use different end-of-line encodings #75

walshawi opened this issue Jan 8, 2020 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed Low Priority Can be cut if needed to meet schedule

Comments

@walshawi
Copy link
Contributor

walshawi commented Jan 8, 2020

This is a common issue for Quake mods: some of the files in the repo have Windows-style CRLF line endings, some have Unix/Linux/Mac-style LF line endings, and at least one file has a mixture of the two. This can cause different issues for people on different systems using different tools to work with the files.

A Git repo can be configured so that it stores the files in a normalized format, so that the Git client can automatically convert to or from whatever scheme is appropriate for the user's system (so Windows users get CRLF, and pretty much everyone else gets LF).

HOWEVER, trying to implement this now would almost certainly cause merge conflicts with unmerged branches. The best time to try to address this would be when the code for the next version is finalized and all branches have been merged.

When we get to that point, I could send you a PR which will implement the above?

I'm posting this here both to ask whether this is OK and so I don't forget about it!

@dumptruckDS
Copy link
Owner

Yes of course. This is a bit over my head so I trust your judgement.

@dumptruckDS dumptruckDS added this to the progs_dump 2.0.1 milestone Mar 11, 2021
@dumptruckDS dumptruckDS modified the milestone: progs_dump 2.0.1 Mar 24, 2021
@dumptruckDS dumptruckDS changed the title Different files use different end-of-line encodings [Bug]Different files use different end-of-line encodings Sep 9, 2021
@dumptruckDS dumptruckDS changed the title [Bug]Different files use different end-of-line encodings [Bug] Different files use different end-of-line encodings Sep 9, 2021
@dumptruckDS dumptruckDS added bug Something isn't working Low Priority Can be cut if needed to meet schedule help wanted Extra attention is needed labels Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed Low Priority Can be cut if needed to meet schedule
Projects
None yet
Development

No branches or pull requests

2 participants