Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip and spell differences #61

Open
7 of 10 tasks
gelguy opened this issue Nov 11, 2016 · 3 comments
Open
7 of 10 tasks

Tooltip and spell differences #61

gelguy opened this issue Nov 11, 2016 · 3 comments

Comments

@gelguy
Copy link
Collaborator

gelguy commented Nov 11, 2016

  • Lancer 5's E tooltip says 1.3 cast delay, but code indicates 1.2
  • Lancer 5's Improved Battle Continuation tooltip says revive is at 25% of max HP, but code revives at fixed 500 HP
  • Archer 5's Sword Rain sword creation tick tooltip says 0.06 but code indicates 0.055
  • Archer 5's Improve Projection attribute increases Kanshou Bakuya's damage but is not indicated in tooltip. Changelog says Kanshou Bakuya is no longer improved.
  • Archer 5's Improve Projection level 2 passive sword damage tooltip indicates 75 but code says 50. Changelog indicates 50 is correct.
  • Lancer 4's Gae Buidhe tooltip says 1.1 cast delay, but code indicates 1.2. Changelog indicates 1.2 is correct.
  • Extra Assassin's R tooltip says 1 second cast delay but code indicates 0.9. Changelog indicates 0.9 is correct.
  • FA's Tsubame Gaeshi tooltip says 1 sec delay but code indicates 0.9. Changelog indicates 0.9 is correct.
  • Avenger's Blood Mark attribute tooltip says it replaces Vengeance Mark
  • Caster 5's Dagger of Treachery attribute tooltip says revoke duration is 7.5 seconds but code says 3 seconds. Mentioned in this changelog.
  • Am I by any chance looking at the wrong numbers? Does the delay key override the AbilityCastPoint field?

Will update this issue with tooltip and spell differences and when they get fixed.

@dun1007
Copy link
Owner

dun1007 commented Nov 11, 2016

delay in AbilitySpecialValue table is usually just for tooltip, unless it is used as a parameter by Lua function

@gelguy
Copy link
Collaborator Author

gelguy commented Nov 11, 2016

Ok, so I think the cast delay discrepancies would be present.

@dun1007
Copy link
Owner

dun1007 commented Nov 29, 2016

For checked ones, code is right and tooltips are wrong/outdated.

Unchecked ones, tooltips/changelogs are right.

Blood Mark no longer replaces Vengeance Mark.

I think I fixed Rule Breaker revoke duration in v1.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants