Fix incorrect coupon calculations #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released as part of v3.2.7. |
|
Hi Duncan. I'm still having my original issue after updating SC. I'm away so next week will do a screen video for you to show the exact issue. |
|
That's weird - I managed to get both of your use cases fixed last night... Although, feel free to send over a video whenever you can and I can take another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two issues with coupon calculation that were mentioned in #651. Both were issues when you entered a decimal number as the coupon value.
This PR contains both the fix and tests to cover both cases.
Fixes #651.