[5.x] Prevent "Are you sure you want to leave this page?" when using Money fieldtype #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems we're doing the same logic on the PHP side in the preProcess method so we don't need to do it here, especially if it's doing exactly the same thing 😅
|
Released as part of v5.3.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should hopefully fix the "Are you sure you want to leave this page?" warning from appearing on any of the publish forms using the Money Fieldtype.
It was being caused by the code in the
mountedmethod of the fieldtype. I've removed it from there in favour of the code in thepreProcessmethod on the PHP side which looks to be doing exactly the same thing.Fixes #897