Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Drop support for gateway being saved as strings on orders #969

Merged
merged 2 commits into from Jan 13, 2024
Merged

[6.x] Drop support for gateway being saved as strings on orders #969

merged 2 commits into from Jan 13, 2024

Conversation

duncanmcclean
Copy link
Owner

@duncanmcclean duncanmcclean commented Jan 13, 2024 •
edited

This pull request completely drops support for Simple Commerce reading gateway data in the legacy string format. Only the array format will be supported.

The array format was introduced quite a while ago now (in v2.4.0, see #498) so it's probably about time we rip of the bandaid and stop supporting it!. Good riddance strings!

Examples

Strings

gateway: \DoubleThreeDigital\SimpleCommerce\Gateways\Builtin\StripeGateway

Arrays

gateway: 
    use: \DoubleThreeDigital\SimpleCommerce\Gateways\Builtin\StripeGateway
    data: 
        id: pi_123456789

@duncanmcclean duncanmcclean marked this pull request as ready for review January 13, 2024 23:43
@duncanmcclean duncanmcclean merged commit bb8caa0 into main Jan 13, 2024
8 checks passed
@duncanmcclean duncanmcclean deleted the remove-support-for-string-gateway-data branch January 13, 2024 23:49
@github-actions GitHub Actions
Copy link

Released as part of v6.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@duncanmcclean